Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo on SignedAmount instead of Amount #1458

Merged

Conversation

oleonardolima
Copy link
Contributor

Description

It fixes the typo on the expect() message introduced on #1426, noticed at #1426 (comment)

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Copy link
Contributor

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 20341a3

@oleonardolima
Copy link
Contributor Author

@notmandatory I think this would need to land in 1.0.0-alpha.13 as well, as it fixes the typo introduced by #1426

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 20341a3

@oleonardolima I'll make sure this one is in the alpha.13 release too.

@notmandatory notmandatory merged commit bc42092 into bitcoindevkit:master Jun 14, 2024
12 checks passed
@oleonardolima oleonardolima deleted the fix/expect-message-typo branch June 14, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants